Prevent local absolute paths from being entered in App config#2814
Prevent local absolute paths from being entered in App config#2814pipecd-bot merged 3 commits intomasterfrom
Conversation
|
Unabled to get changed files of pull request. Details |
|
Code coverage for golang is
|
|
|
||
| func (r *Reporter) readApplicationInfo(ctx context.Context, cfgFilePath string) (*model.ApplicationInfo, error) { | ||
| b, err := fs.ReadFile(r.fileSystem, cfgFilePath) | ||
| func (r *Reporter) readApplicationInfo(appPath, cfgFileAbsPath string) (*model.ApplicationInfo, error) { |
There was a problem hiding this comment.
Sorry, it should be repoDir, appDirRelPath, cfgFilename
There was a problem hiding this comment.
I mean we should use the same thing in our code and data in db, they are appPath and cfgFilename, and repoDir is added for dealing with the local file system.
Co-authored-by: Le Van Nghia <nghialv2607@gmail.com>
|
@nghialv Applied! PTAL |
|
Looks nice. |
|
Code coverage for golang is
|
|
Nice |
|
This pull request is APPROVED by Approvers can cancel the approval by writing |
4 participants
What this PR does / why we need it:
This PR solves the problem where Piped would specify a local absolute path as GitPath when reporting a Git-defined Config to Control-plane.
Which issue(s) this PR fixes:
Close #2806
Does this PR introduce a user-facing change?: